Inject data only when renders via Meteor#2
Open
timbrandin wants to merge 1 commit intometeorhacks:masterfrom
studiointeract:fast-render-108
Open
Inject data only when renders via Meteor#2timbrandin wants to merge 1 commit intometeorhacks:masterfrom studiointeract:fast-render-108
timbrandin wants to merge 1 commit intometeorhacks:masterfrom
studiointeract:fast-render-108
Conversation
…e when to inject fast render data.
Member
There was a problem hiding this comment.
Is this correct? Seems bit confusing to me?
Author
There was a problem hiding this comment.
I know, a bit odd. But it works with SSR with _escaped_fragment_ this way.
Member
|
I've another suggestion to make this work.
Does that suits with your use case? |
Author
|
Oh, yeah that would work. I guess in my use case I'm still rendering via Meteor but don't want the big script tag for |
Author
|
I wonder if you get the script tag on SSR for E-mail too? |
Member
|
Okay. Then let's do a check for the URL for |
Author
|
The URL doesn't seem to be available in the current context. Any ideas? |
Member
|
Yes. Then let's do that check in the fast-render. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look for text/html in the content type on the request to better decide when to inject fast render data.